Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unleashed #578

Closed
wants to merge 14 commits into from
Closed

Unleashed #578

wants to merge 14 commits into from

Conversation

IhimeraBishop
Copy link

DarkflipperBackground

Please, describe here why you create this PR

Changes

Here what change in this PR..

Test plan

..and how we can test it

@LionZXY
Copy link
Member

LionZXY commented May 5, 2023

Very cool!
There are a few things that could make your job easier:

  1. You can simply turn off the metric with the flag. Not a single line of code with the metric will get into your build, you can check this with jadx, for example
  2. Instead of skipping subghz provisioning you could provide the file you want, that way the app would update the file even on official firmware
  3. Instead of hardcode replacing the update link you could make a switch in the settings so that even those using official firmware could use the app (like here: Add firmware update custom url #452)
  4. You can add support for self-updater. See here

@LionZXY LionZXY closed this May 5, 2023
@Denlo94 Denlo94 linked an issue May 12, 2023 that may be closed by this pull request
Copy link

@Denlo94 Denlo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

@Denlo94 Denlo94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md

@Denlo94 Denlo94 mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

> **Is your feature request related to a problem? Please describe.**
5 participants