Require properties of dynamic types to be initialized #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklinsch
force-pushed
the
all-properties-inited
branch
from
49bc456 to
c994c24
Compare
|
Awesome @franklinsch ! I believe the grammar has to be updated too. Currently it assumes assignment is optional. From my experience programming in OCaml/C++, explicit assignment requirement makes things clear & safe. |
|
Strongly agree :) The rule is: each property needs to be assigned a default value at the declaration site, or by the end of the struct/contract's initializer. This semantic test describes it: https://github.com/franklinsch/flint/blob/master/Tests/SemanticTests/inits.flint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.