Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input escape mapping #311

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: input escape mapping #311

wants to merge 2 commits into from

Conversation

Skn0tt
Copy link
Collaborator

@Skn0tt Skn0tt commented Jan 17, 2025

Closes #310

There's a bug in the path escaping logic where meta was applied to the wrong values. This PR fixes the escape bug. It also introduces a version tag to toggle the path escaping when deserializing. This ensures backwards compatibility for SuperJSON results that were created on a version with the bug.

@Skn0tt Skn0tt requested a review from Copilot January 17, 2025 09:03
@Skn0tt Skn0tt self-assigned this Jan 17, 2025
@Skn0tt Skn0tt changed the title Input escape mapping fix: input escape mapping Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/index.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

src/pathstringifier.test.ts:11

  • The expected output for the input 'test\a.b' should be ['test\a', 'b'] based on the escaping logic.
['test\\a.b', ['test\a', 'b']]
@Skn0tt Skn0tt mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input mapping is buggy
1 participant