Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up coveralls code coverage reporting #98

Merged
merged 3 commits into from
Mar 27, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Mar 19, 2016

This pull request adds code coverage testing and reporting the result to coveralls.

@jslee02
Copy link
Member Author

jslee02 commented Mar 21, 2016

coveralls reported as a failure because I set the coverage threshold for failure to 50.0% at first. It's relaxed to 49.0% so the test should be passed, but the result seems not being updated.

@jslee02 jslee02 added this to the FCL 0.5.0 milestone Mar 21, 2016
@jslee02
Copy link
Member Author

jslee02 commented Mar 27, 2016

Can we merge this? Coverage test would be a good tool for managing the code quality.

@@ -12,3 +12,6 @@ cd build
cmake ..
make
sudo make install

# Code-coverage
sudo apt-get -qq --yes --force-yes install lcov curl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe delete this and add lcov and curl to the packages list in travis.yml (assuming that lcov and curl have been whitelisted by Travis CI)? This would allow them to be cached by Travis.

@mamoll
Copy link
Member

mamoll commented Mar 27, 2016

👍

@jslee02 jslee02 merged commit c821b10 into flexible-collision-library:master Mar 27, 2016
@davetcoleman
Copy link

This is a really cool feature, I'm sure you are too busy @jslee02 but moveit could sure use this coverage feature!

@jslee02
Copy link
Member Author

jslee02 commented Jul 19, 2016

@davetcoleman Yeah, I found coverage reporting feature is useful so am using this for DART (another my major open source project) as well. It would be straightforward to setup this feature to moveit thanks to coveralls and coveralls-cmake. Please let me know if there something I could help.

@davetcoleman
Copy link

i've added this to my moveit todo list, will probably ping you later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants