Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace non-portable M_PI reference with fcl::constants invocation #264

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/test_fcl_cylinder_half_space.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@

#include <iostream>

#include "fcl/fcl.h"
#include <gtest/gtest.h>

#include "gtest/gtest.h"
#include "fcl/fcl.h"

using namespace std;
using namespace fcl;
Expand Down Expand Up @@ -77,7 +77,8 @@ void test_collision_cylinder_half_space(fcl::GJKSolverType solver_type)
EXPECT_NEAR(contacts[0].penetration_depth, 0.051, kTolerance);

// Now perform the same test but with the cylinder's z axis Cz pointing down.
X_WC.linear() = AngleAxis<S>(M_PI, Vector3d::UnitX()).matrix();
X_WC.linear() = AngleAxis<S>(fcl::constants<S>::pi(),
Vector3d::UnitX()).matrix();
X_WC.translation() = Vector3<S>(0, 0, 0.049);
cylinder_co.setTransform(X_WC);

Expand Down