Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update general_test.cpp #188

Merged
merged 2 commits into from
Nov 11, 2016
Merged

Update general_test.cpp #188

merged 2 commits into from
Nov 11, 2016

Conversation

jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 10, 2016

This PR updates general_test.cpp for the new API, which should address #186.

I think this test could be replaced by this. If this makes sense then we could remove this test.

@jslee02 jslee02 added this to the FCL 0.6.0 milestone Nov 10, 2016
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Coveralls is complaining about a drop in coverage?

@jslee02
Copy link
Member Author

jslee02 commented Nov 10, 2016

I think it's because of that this test checks for both of float and double types while the other tests don't. fcl_test_general.cpp generates template code for float type, but the generated code is not covered by other tests. I just disabled other tests for float not to double the testing time.

I'm not sure if we want to test for float type besides double. If it's not, we could just disable the float test of fcl_test_general.cpp.

@jslee02
Copy link
Member Author

jslee02 commented Nov 11, 2016

I believe AppyVeyor test will pass if we re-run it. I'll fix it if it still exists after this PR is merged.

Also, the coverage is restored by removing the test for float type.

@jslee02 jslee02 merged commit 098e939 into master Nov 11, 2016
@jslee02 jslee02 deleted the general_test branch December 9, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants