-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Eigen for math operations #150
Conversation
Some minor comments on the CMake parts of this PR, that can be probably fixed in other PRs .
[1] : https://bitbucket.org/eigen/eigen/src/8267656b597c03c7fe501be33056cda9a63e88ab/cmake/FindEigen3.cmake?at=default&fileviewer=file-view-default |
Thanks for the comments! I just didn't know that there is an officially distributed |
Yes, it makes sense to adopt the changes in |
Eigen conversion looks great, @jslee02. Very nice to see files get deleted! |
Just a note that I'm compiling moveit_core and it throw out these compile error. |
For completion: |
This PR switches to Eigen for the math operations as suggested (#96).
The goal of this PR is to pass all the unit tests with equal to or better than the previous computational performance, and it seems it's achieved as of now. Other possible improvements (e.g., the templatizing suggested by @sherm1 (comment)) might be done in a separate PR.
Here are several todos that will be done in this PR:removing repetitive conversion between quaternion and rotation matrixutilizing lazy evaluationutilizing aliasingEdit: Above todos will be done in future PRs to keep this PR as simple as possible for code review.