add option to disable octomap in build #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. nitpick: Could we add |
v4hn
force-pushed
the
with-octomap-option
branch
from
0e971c4
to
15a0d9c
Compare
|
done
|
|
another nitpick: For the default value, I believe either |
This is a quasi-standard pattern to allow users to test the library without its optional-dependency even if the dependency is available.
v4hn
force-pushed
the
with-octomap-option
branch
from
15a0d9c
to
7526e56
Compare
|
Hehe, there you go, oh great maintainer of this wonderful library. :-)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quasi-standard pattern to allow users to test the library without
its optional-dependency even if the dependency is available.