Made the granting of privileges idempotent #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 29, 2012 22:19
Changed the grants for the user role to use explicit grants rather than using a grant all and revoke super. This should resolve an issue when using RightScale MySQL templates and employing a single username and password for all roles for the DB
The previous code when used in our templates caused replication to be broken when using the same username and password for admin / replication and the application DB users. The issue was caused by the use of revoke which instead of setting the appropriate privileges removed the super privilege from the user removing the ability to set the master host. i.e not idempotent. This is resolved by just granting the appropriate ones and therefore not revoking required ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of the cookbooks/db_mysql/definitions/db_mysql_set_privileges.rb conifgured a 'user' by granting all and revoking the super privilege. When using this with a single username / password for all user types in the mysql template the last action taken is to revoke the super priv from the user. This prevents the slave from configuring replication.