Set grid size for union of GDSII shapes #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a grid size, the default from shapely is `double` precision, which leads to artifacts in the final geometry. Because the GDSII cordinates are already snapped to a grid, this should have no adverse effect unless the GDSII grid is finer than 1e-12. The usual default in GDSII files is for precision to be 1e-9 with unit 1e-6, that is a grid size of 1e-3, so the chosen value of 1e-12 should be quite safe. Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>
lucas-flexcompute
force-pushed
the
lucas/gdsii_union
branch
from
28f2751
to
ae132b0
Compare
tylerflex
approved these changes
Mar 21, 2023
weiliangjin2021
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a grid size, the default from shapely is
doubleprecision, which leads to artifacts in the final geometry. Because the GDSII cordinates are already snapped to a grid, this should have no adverse effect unless the GDSII grid is finer than 1e-12. The usual default in GDSII files is for precision to be 1e-9 with unit 1e-6, that is a grid size of 1e-3, so the chosen value of 1e-12 should be quite safe.