Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting a lot of divide by zero warnings in the
np.linalg.det
calls from the mode solver.Digging into the issue, I found it was because taking a determinant of a complex-valued identity matrix triggers this warning, which was the case for the jacobians in the mode solver that were being passed to
np.linalg.det
.To fix this, I casted the jacobians to
np.real
.@momchil-flex @weiliangjin2021 @dbochkov-flexcompute is this safe you think? or worth worrying about? I tried filtering the warning but don't know if we want to do that more generally in case we should be worrying about this.