TFSF #672
Merged
TFSF #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Looks really good. Man, that's a lot of validators. Just a few mostly formatting things and also some comments about refactoring the TFSF and Source plotting, which would be good to do anyway. Thanks @shashwat-sh !
|
Thanks @tylerflex, I've made the changes. |
tylerflex
approved these changes
Jan 30, 2023
tylerflex
reviewed
Jan 30, 2023
shashwat-sh
force-pushed
the
shash/tfsf
branch
3 times, most recently
from
e304061
to
9106e1a
Compare
tylerflex
force-pushed
the
pre/1.9.0
branch
2 times, most recently
from
c6d8b80
to
9859e8a
Compare
momchil-flex
force-pushed
the
pre/1.9.0
branch
2 times, most recently
from
7acc7b1
to
d58051e
Compare
shashwat-sh
force-pushed
the
shash/tfsf
branch
from
9106e1a
to
d860964
Compare
momchil-flex
reviewed
Mar 2, 2023
- added symmetry and boundary validators for tfsf - modified TFSF plotting so that the arrows are on the injection plane; added injection_plane_center convenience property - updated surfaces to handle the case of a surface at infinity - added an option in CustomGrid to use a custom offset for defining the global coords of the custom grid, rather than the sim center - adjusted tfsf validator description - bloch boundary supports TFSF sources - add sim method to get intersecting structures - add sim pre upload validator to check that all side faces of a TFSF box see the same epsilon profile - modification to source normalization for Bloch+TFSF - add TFSF boundary and bloch validators - updated tfsf tests - added more frontend tests and fixed a validator bug - plotting improvement and other fixes based on PR672 review - minor plotting fix - update bloch vec checker - update tests for bloch checker - update tests after rebase and deleted orig files - revised based on PR672 review - added a validator for custom media intersecting a TFSF box - modify assert volume validator to hint at handling 2D simulations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Total-field scattered-field feature.
Associated backend PR: https://github.com/flexcompute/tidy3d-core/pull/223
Notebook (for now uses local solver):
https://github.com/flexcompute-readthedocs/tidy3d-docs/blob/shash/tfsf/docs/source/notebooks/TFSF.ipynb
To do: