add ssl verify #629
Merged
add ssl verify #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an-li-the-dev
force-pushed
the
feature/ssl_verify
branch
3 times, most recently
from
a7d0cc4
to
5a0e9fe
Compare
an-li-the-dev
force-pushed
the
feature/ssl_verify
branch
from
5a0e9fe
to
267b06c
Compare
|
Looks good to me and I did some testing too. Note that now that you have introduced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added environment name TIDY3D_SSL_VERIFY checking.
Default value is True.
When user
export TIDY3D_SSL_VERIFY=false, it will skip certification verify.Please note that the name is TIDY3D_SSL_VERIFY, instead of TIDY3d_DISABLE_SSL which is used in hotfix branch.