Near2Far refactor phase 1: changes to storage and access of far fields #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behaviour:
fields
method which returned fields in a coordinate system that depended on the monitor, e.g. spherical for the angle monitor, Cartesian for the Cartesian monitorr
to project fields to that given distanceNew behaviour
fields_spherical
fields_cartesian
radar_cross_section
power
so that all quantities are available for all monitors, and in both coordinate systems.
1m
.renormalize_fields(distance)
so that all fields stored in the data become renormalized to the new distance.Rationale:
renormalize_fields
won't be available because the phase is "baked into" the exact Green's function.Backend PR: #557