Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix throw KeyError exception when sources element is not correct #456

Merged
merged 1 commit into from
Aug 5, 2022
Merged

fix throw KeyError exception when sources element is not correct #456

merged 1 commit into from
Aug 5, 2022

Conversation

JunchengXue
Copy link
Contributor

@JunchengXue JunchengXue commented Aug 5, 2022 •
edited
Loading

If element in sources is incorrect, the values does not have key sources, so it will throw KeyError exception. It will block the correct pydantic ValidationError throw.

@tylerflex tylerflex merged commit e11bd0f into develop Aug 5, 2022
@tylerflex tylerflex deleted the feature/fix-source-key-error branch August 5, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@momchil-flex momchil-flex Awaiting requested review from momchil-flex

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunchengXue @tylerflex