Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tidy3d components immutable #408

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Conversation

tylerflex
Copy link
Collaborator

@tylerflex tylerflex commented Jun 10, 2022

To do list:

  • Make front end immutable, passing all tests.
  • make Tidy3dBaseModel.__config__.frozen = True
  • copy with update.
  • handle caching of properties automatically assuming immutability (simplified).
  • test construct() to see if it works.
  • fix any backend tests that fail.
  • update all notebooks.
  • update docs with FAQ section about this, why we did it, what changes.

@tylerflex tylerflex changed the title first pass at immutability Make tidy3d immutable Jun 10, 2022
@tylerflex tylerflex changed the title Make tidy3d immutable Make tidy3d components immutable Jun 10, 2022
@momchil-flex momchil-flex merged commit 239aa6f into develop Jun 25, 2022
@tylerflex tylerflex deleted the feature/immutability branch August 24, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix cases where validator use isn't robust to model changes pydantic anti patterns
2 participants