Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error message if only one bound is inf #325

Merged
merged 2 commits into from
Apr 19, 2022
Merged

error message if only one bound is inf #325

merged 2 commits into from
Apr 19, 2022

Conversation

tylerflex
Copy link
Collaborator

No description provided.

@tylerflex tylerflex requested a review from xin-flex April 19, 2022 17:41
@tylerflex tylerflex linked an issue Apr 19, 2022 that may be closed by this pull request
Copy link
Contributor

@xin-flex xin-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified it as:

Bounds of (-inf, 4) supplied along one dimension. We currently don't support a single inf value in bounds for Box. To construct a semi-infinite Box, please supply a large number instead of inf so that this bound extends outside of the Simulation domain including PML.

@tylerflex
Copy link
Collaborator Author

tylerflex commented Apr 19, 2022

Thanks, I actually edited this just a bit. Because the from_bounds is not necessarily used for within Simulation, I just made the error message a bit more general. Feel free to suggest a different edit and I'll change it

"Bounds of (pt_min, pt_max) supplied along one dimension. 
We currently don't support a single ``inf`` value in bounds for ``Box``. 
To construct a semi-infinite ``Box``, please supply a large enough number instead of ``inf``. 
For example, a location extending outside of the Simulation domain (including PML)."

@tylerflex tylerflex requested a review from xin-flex April 19, 2022 22:17
@tylerflex tylerflex merged commit 88f6a4f into develop Apr 19, 2022
@tylerflex tylerflex deleted the tyler/semi_inf branch April 19, 2022 22:38
daquinteroflex pushed a commit to daquinteroflex/tidy3d that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Semi Infinite Bounds
2 participants