Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treating one edge case of intersect_side in PolySlab #323

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Treating one edge case of intersect_side in PolySlab #323

merged 1 commit into from
Apr 20, 2022

Conversation

weiliangjin2021
Copy link
Collaborator

No description provided.

tylerflex
tylerflex requested changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that some of the conditionals are difficult to read. Can we break them up a bit more? I put specific comments. @xin-flex can you test the results look good?

@weiliangjin2021
Copy link
Collaborator Author

My only comment is that some of the conditionals are difficult to read. Can we break them up a bit more? I put specific comments. @xin-flex can you test the results look good?

Somehow I don't see your specific comments?

@tylerflex tylerflex linked an issue Apr 19, 2022 that may be closed by this pull request
PolySlab Intersection Bug #308
Closed
@weiliangjin2021
Copy link
Collaborator Author

@tylerflex Please take a look again.

xin-flex
xin-flex requested changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@xin-flex xin-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
I tested the same case, the two waveguides become symmetric, but they are now both cones instead of polyslab. Compare to another cross-section which renders correctly:
image

@tylerflex tylerflex self-requested a review April 19, 2022 21:23
tylerflex
tylerflex approved these changes Apr 19, 2022
View reviewed changes
tidy3d/components/geometry.py Outdated Show resolved Hide resolved
tidy3d/components/geometry.py Outdated Show resolved Hide resolved
@tylerflex tylerflex merged commit 3a10d9f into develop Apr 20, 2022
@tylerflex tylerflex deleted the weiliang/polyslab branch April 20, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xin-flex xin-flex xin-flex approved these changes

@tylerflex tylerflex tylerflex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PolySlab Intersection Bug
3 participants
@weiliangjin2021 @tylerflex @xin-flex