fix bug in autograd differentiation cylinder.center #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/autograd_/fix/cylinder_center
branch
from
1740071
to
a43919d
Compare
momchil-flex
approved these changes
Nov 1, 2024
|
Looks good but tests are failing. |
tylerflex
force-pushed
the
tyler/autograd_/fix/cylinder_center
branch
4 times, most recently
from
028c2c4
to
2ef0662
Compare
tylerflex
force-pushed
the
tyler/autograd_/fix/cylinder_center
branch
from
2ef0662
to
08f67ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the cylinder is differentiated w.r.t but not the radius, there's a bug that wasn't caught in tests.