Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-upload validating server autograd runs and optimizer #2038

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

momchil-flex
Copy link
Collaborator

@momchil-flex momchil-flex commented Oct 25, 2024

  • Add validate_pre_upload() call to the forward simulation with monitors when called in a server autograd run. The adjoint simulation includes the monitors already.
  • Modify the optimizer validate_pre_upload() method to call the corresponding method for the embedded simulation.

@momchil-flex momchil-flex force-pushed the momchil/validate_pre_upload branch 2 times, most recently from 7cd3dd3 to f70001a Compare October 25, 2024 11:50
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, guess this answers my question on the core PR?

@momchil-flex
Copy link
Collaborator Author

looks good, guess this answers my question on the core PR?

Ah, yes, I answered that one there first before seeing this. :)

@momchil-flex momchil-flex merged commit 143efcf into develop Oct 28, 2024
15 checks passed
@momchil-flex momchil-flex deleted the momchil/validate_pre_upload branch October 28, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants