Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to xarray>=2023.08.0 #1925

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Bump to xarray>=2023.08.0 #1925

merged 1 commit into from
Aug 30, 2024

Conversation

yaugenst-flex
Copy link
Contributor

Need to bump xarray because we depend on xr.DataArray.coords.copy() quite a bit, which is not implemented for xarray<2023.08.0. A user encountered this error because they were using an older xarray version.

This technically is a bug that exists across most previous releases, not sure how this would be handled (i.e., where is this supposed to get merged into?).

@yaugenst-flex yaugenst-flex added the Bug something isnt working label Aug 28, 2024
@daquinteroflex
Copy link
Collaborator

daquinteroflex commented Aug 28, 2024

Good catch. We could technically add a little FAQ on the docs if we believe it to be useful. One other thing I personally find useful, is that people running into a similar error as that user could simply search on google the error first. If we have a traceback on an github issue/PR such as this one, then they should be able to know how to fix it. Re-patching a release wouldn't be feasible, but we can just make sure our latest version is correct onwards so just ask them to update to that.

This is just what comes to mind, maybe there's a better approach you might have in mind?

@yaugenst-flex
Copy link
Contributor Author

Sounds good to me. I guess the way to handle this through releases is via maintaining older branches and doing maintenance/bugfix releases on those. Eventually we might want to do that, but I agree it's not feasible currently.

@yaugenst-flex yaugenst-flex added 2.7 will go into version 2.7.* .3 and removed Bug something isnt working labels Aug 29, 2024
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah just bumping the version if it's problematic seems acceptable to me. We've done it before for other deps too...

@yaugenst-flex yaugenst-flex merged commit 7f4351b into develop Aug 30, 2024
15 checks passed
@yaugenst-flex yaugenst-flex deleted the yaugenst-flex/bump-xarray branch August 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.7 will go into version 2.7.* .3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants