Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Simulation.num_computational_cells property #1903

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

momchil-flex
Copy link
Collaborator

No description provided.

Copy link
Contributor

@alec-flexcompute alec-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If it passes these tests you wrote I think it should be good to go

Copy link
Collaborator

@e-g-melo e-g-melo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @momchil-flex!

I would suggest another name because num_cells sounds very similar to num_computational_cells. But, you have explained the difference in the documentation, so that is not critical. It is up to you.

@momchil-flex
Copy link
Collaborator Author

I would suggest another name because num_cells sounds very similar to num_computational_cells. But, you have explained the difference in the documentation, so that is not critical. It is up to you.

I'm open do discussion, I just thought that num_computational_cells makes it a bit clearer what the difference from num_cells is, as opposed to just grid_points. But I could change to num_computational_grid_points to be more in line with the log and GUI? It's a bit unfortunate that we use cells in some places and points in others.

@e-g-melo
Copy link
Collaborator

I'm open do discussion, I just thought that num_computational_cells makes it a bit clearer what the difference from num_cells is, as opposed to just grid_points. But I could change to num_computational_grid_points to be more in line with the log and GUI? It's a bit unfortunate that we use cells in some places and points in others.

That is true! We should have used the same name. Optionally, we could change grid points to grid cells in Log, GUI, and the documentation. Do you think that would cause confusion?

@momchil-flex
Copy link
Collaborator Author

Yeah I think unfortunately that could be confusing too as it will e.g. appear differently in the log for different solver versions...

@momchil-flex
Copy link
Collaborator Author

I guess I'll just go with num_computational_grid_points here.

@momchil-flex momchil-flex force-pushed the momchil/num_computational_cells branch from 98e6445 to db459f0 Compare August 21, 2024 08:00
@momchil-flex momchil-flex merged commit 53ef995 into develop Aug 21, 2024
15 checks passed
@momchil-flex momchil-flex deleted the momchil/num_computational_cells branch August 21, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants