-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Simulation.num_computational_cells property #1903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If it passes these tests you wrote I think it should be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @momchil-flex!
I would suggest another name because num_cells
sounds very similar to num_computational_cells
. But, you have explained the difference in the documentation, so that is not critical. It is up to you.
I'm open do discussion, I just thought that |
That is true! We should have used the same name. Optionally, we could change grid points to grid cells in Log, GUI, and the documentation. Do you think that would cause confusion? |
Yeah I think unfortunately that could be confusing too as it will e.g. appear differently in the log for different solver versions... |
I guess I'll just go with |
98e6445
to
db459f0
Compare
No description provided.