Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return modes info table even if fields not available #1884

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Return modes info table even if fields not available #1884

merged 1 commit into from
Aug 6, 2024

Conversation

dbochkov-flexcompute
Copy link
Contributor

No description provided.

momchil-flex
momchil-flex approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's funny, looking at the code it seems like that was what was intended even? Otherwise no reason to have that separate check to populate the field-requiring variables only if fields are present. Not just populate, re-compute!

@momchil-flex momchil-flex merged commit 003b37a into develop Aug 6, 2024
15 checks passed
@momchil-flex momchil-flex deleted the daniil/fix-mode-table branch August 6, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbochkov-flexcompute @momchil-flex @tylerflex