Restricting allowed ModeSolver.plane types #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
approved these changes
Aug 6, 2024
| @@ -74,6 +75,7 @@ | |||
|
|
|||
| MODE_SIMULATION_TYPE = Union[Simulation, EMESimulation] | |||
| MODE_SIMULATION_DATA_TYPE = Union[SimulationData, EMESimulationData] | |||
| MODE_PLANE_TYPE = Union[Box, ModeSource, ModeMonitor, ModeSolverMonitor] | |||
There was a problem hiding this comment.
why not allow other source and monitor types? or even Mode Simulation types?
There was a problem hiding this comment.
So my thinking is that if I could just do what I want, I would just require this to always be Box so the definition is clear and there's no wide range of types that this attribute can take. So I kind of took the route of allowing the minimum extra that should preserve compatibility at least within our examples. Technically you are right though that some people may have used this in other ways too, e.g. passing other monitors. Probably quite an edge case but not impossible. So.. not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.