-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 Update the submodule checks #1871
Conversation
5d8cec0
to
626ad43
Compare
626ad43
to
c1a65bd
Compare
c1a65bd
to
76619f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I like this. :) Hopefully the last time we revisit...
Code looks good overall but only way to know if it works as expected is through testing. I know you did some already so let's get this in and then monitor for inconsistencies.
Sounds good! Also to update the daily tests run as expected https://github.com/daquinteroflex/tidy3d/actions/runs/10226877623 |
Unfortunately no. I was looking into this for another action yesterday and it seems like it's not easy to control who gets notification. Only the user who created the action does. :( |
We could use this solution possibly: https://stackoverflow.com/questions/62304258/github-actions-notifications-on-workflow-failure what do you think? |
Hi Momchil,
I think this implements the test-submodule implementation we chatted about.
Let me know any thoughts.
pre/*
anddevelop
branches once a day.I have tested the daily and latest PR workflow run as expected in my fork:
I can do full release demoing in my fork too to thoroughy test the flow but logically think it should work as is.