Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Update the submodule checks #1871

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Jul 31, 2024

Hi Momchil,

I think this implements the test-submodule implementation we chatted about.

Let me know any thoughts.

  • Performs all checks on PRs onto latest
  • Does a test submodule check before the release process occurs.
  • Perform the submodule checks on the pre/* and develop branches once a day.

I have tested the daily and latest PR workflow run as expected in my fork:

I can do full release demoing in my fork too to thoroughy test the flow but logically think it should work as is.

@daquinteroflex daquinteroflex marked this pull request as ready for review July 31, 2024 19:50
@daquinteroflex daquinteroflex changed the title 🔨 Update the submodule checks as discussed 🔨 Update the submodule checks Jul 31, 2024
@daquinteroflex daquinteroflex marked this pull request as draft August 1, 2024 08:33
@daquinteroflex daquinteroflex removed the request for review from momchil-flex August 1, 2024 09:03
@daquinteroflex daquinteroflex marked this pull request as ready for review August 1, 2024 21:00
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I like this. :) Hopefully the last time we revisit...

Code looks good overall but only way to know if it works as expected is through testing. I know you did some already so let's get this in and then monitor for inconsistencies.

@daquinteroflex
Copy link
Collaborator Author

Sounds good! Also to update the daily tests run as expected https://github.com/daquinteroflex/tidy3d/actions/runs/10226877623

@daquinteroflex daquinteroflex merged commit 8ea39ee into develop Aug 5, 2024
15 checks passed
@daquinteroflex daquinteroflex deleted the dario/change_submodule_checks branch August 5, 2024 09:15
@daquinteroflex
Copy link
Collaborator Author

Just thought to check if you also get the notifications now that it's running:

image

@momchil-flex
Copy link
Collaborator

Unfortunately no. I was looking into this for another action yesterday and it seems like it's not easy to control who gets notification. Only the user who created the action does. :(

@daquinteroflex
Copy link
Collaborator Author

We could use this solution possibly: https://stackoverflow.com/questions/62304258/github-actions-notifications-on-workflow-failure what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants