Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to [email protected] #1858

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

yaugenst-flex
Copy link
Contributor

@yaugenst-flex yaugenst-flex commented Jul 29, 2024

Updating to latest ruff. Linter catching some additional errors, which I fixed.

@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/update-ruff branch 2 times, most recently from e517037 to 3cf3300 Compare July 29, 2024 12:50
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess people might need to make sure to update their local ruff versions for compatibility?

@yaugenst-flex
Copy link
Contributor Author

yaugenst-flex commented Jul 29, 2024

I'm assuming people upgrade their poetry venv on branch checkouts 😄 but otherwise yeah, you'll have to update. The formatting is unaffected, but there are some slight linting differences.

I'm trying to do these updates a little more frequently so that we don't end up with a huge chunk of changes at once like last time.

@yaugenst-flex yaugenst-flex merged commit 092b209 into develop Jul 30, 2024
16 checks passed
@yaugenst-flex yaugenst-flex deleted the yaugenst-flex/update-ruff branch July 30, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants