-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small fix to changelog #1852
Small fix to changelog #1852
Conversation
96fd9cc
to
aa22737
Compare
Hm seems tricky to automatically merge changelogs from those two branches as long as they both write to the same section of the changelog but have different target sections. Resolving manually seems quite ok generally? Alternatively, we could only merge |
Seems a bit error prone, otherwise not too painful...
That's kind of what we'd been doing until now. I think there were a couple of reasons to want to merge now, the readthedocs sync action was broken on pre/2.8 and @caseyflex needs to develop a 2.8 feature on top of code that's currently in |
I see. I guess another alternative, similar to what you mentioned, would be to just put changes in |
Hm yeah I like that! |
Yeah I like this approach too as it separates the relevant sections cleanly! |
aa22737
to
8b22626
Compare
One item that was not yet released had made it in 2.7.1 changelog instead of in the unreleased section.
I updated this changelog to be in line with the one in the pre/2.8 branch after we just merged develop there. There's generally a bit of an issue with the changelog when we do such merges. Both branches have Unreleased section where we put new things. When we do a merge, those two get merged and the items that should go in the next patch vs. the next minor release get intertwined.
This is probably at least partly caused by this merge strategy I introduced a long time ago when the changelog was causing conflicts in almost every PR (maybe exacerbated by us using rebase rather than merge workflow).
We could try removing this and then probably manually resolving things more often, but at least will hopefully not be reaching a point where it's not clear what item came from where?
Or we could try to use a different strategy, like have avoiding putting the things under the same
Unreleased
header, and use the next version header instead even if unreleased? This is what I did here by explicitly introducing the 2.7.2 section.