Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated validator for 2D far field projection to include FieldProjectionCartesianMonitor #1850

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

QimingFlex
Copy link
Contributor

@QimingFlex QimingFlex commented Jul 22, 2024

Thanks to comments from @yaugenst-flex , the verbosity of the code has been greatly reduced. It's now ready for a final review by @momchil-flex .

Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QimingFlex

Copy link
Contributor

@yaugenst-flex yaugenst-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Only a minor comment regarding the validation.

tidy3d/components/simulation.py Outdated Show resolved Hide resolved
@QimingFlex QimingFlex marked this pull request as ready for review August 5, 2024 12:58
@QimingFlex QimingFlex force-pushed the qiming/2d_car_farfield branch 3 times, most recently from 6724ba3 to 6e88bd6 Compare August 5, 2024 14:39
@momchil-flex momchil-flex merged commit 3de1e67 into develop Aug 5, 2024
1 check passed
@momchil-flex momchil-flex deleted the qiming/2d_car_farfield branch August 5, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants