refc: replace assert statements
#1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
commented
Jul 15, 2024
yaugenst-flex
commented
Jul 15, 2024
yaugenst-flex
force-pushed
the
yaugenst-flex/remove-asserts
branch
from
4940ccc
to
d5dcc25
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/remove-asserts
branch
from
d5dcc25
to
3934e7b
Compare
yaugenst-flex
force-pushed
the
yaugenst-flex/remove-asserts
branch
from
3934e7b
to
5258223
Compare
|
@momchil-flex this is ready to go, might want to wait until after #1846 though |
tylerflex
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1833
Replaces all
assertstatements intidy3d/by checking for and raising exceptions. I made an attempt to infer some error messages and error types.Also updates our linting rules to forbid
asserts.Should be merged after #1834