fix PolySlab in autograd gradient when sidewall_angle or dilation used
#1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerflex
force-pushed
the
tyler/autograd_/fix/polyslab
branch
from
8c88488
to
6000952
Compare
yaugenst-flex
approved these changes
Jul 1, 2024
No, these don't work yet. In fact, I'm not super sure how to define them (at least how to define gradient w.r.t sidewall_angle). Before this fix, basically everything worked fine, but I never tested with a non-zero dilation or sidewall angle. It turned out things broke. I will update the changelog to be more specific, I see how this is a bit confusing. |
tylerflex
force-pushed
the
tyler/autograd_/fix/polyslab
branch
from
6000952
to
6b48d0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.