Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiable n-dimensional nearest and linear interpolation for DataArray #1769

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Differentiable n-dimensional nearest and linear interpolation for DataArray #1769

merged 1 commit into from
Jul 8, 2024

Conversation

yaugenst-flex
Copy link
Contributor

@yaugenst-flex yaugenst-flex commented Jun 17, 2024 •
edited
Loading

Implements differentiable interpolation methods for DataArray.

  • Implement interpolation function in plugins/autograd/functions.py.
  • Write tests & documentation for above.
  • Integrate into td.DataArray.
  • Test DataArray implementation.

@tylerflex tylerflex mentioned this pull request Jun 19, 2024
Open
95 tasks
@yaugenst-flex yaugenst-flex mentioned this pull request Jun 19, 2024
Merged
@yaugenst-flex yaugenst-flex changed the base branch from develop to pre/2.8 June 28, 2024 14:29
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-interp branch 2 times, most recently from e4fcb00 to adcdf69 Compare July 1, 2024 13:21
@yaugenst-flex yaugenst-flex self-assigned this Jul 2, 2024
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-interp branch 2 times, most recently from dfa68bb to 511e3be Compare July 3, 2024 13:44
tylerflex
tylerflex requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yaugenst-flex , let's discuss these last few things but overall looks great

tests/test_components/test_autograd.py Show resolved Hide resolved
tests/utils.py Outdated Show resolved Hide resolved
tidy3d/components/autograd/derivative_utils.py Outdated Show resolved Hide resolved
tidy3d/components/autograd/functions.py Show resolved Hide resolved
tidy3d/components/autograd/functions.py Show resolved Hide resolved
tidy3d/components/data/data_array.py Outdated Show resolved Hide resolved
tidy3d/components/data/data_array.py Outdated Show resolved Hide resolved
tidy3d/components/data/data_array.py Outdated Show resolved Hide resolved
tidy3d/components/data/data_array.py Show resolved Hide resolved
tidy3d/components/data/monitor_data.py Outdated Show resolved Hide resolved
@tylerflex tylerflex added the 2.7 will go into version 2.7.* label Jul 3, 2024
dmarek-flex
dmarek-flex reviewed Jul 3, 2024
View reviewed changes
tests/utils.py Outdated Show resolved Hide resolved
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-interp branch from d9ea683 to c96525a Compare July 4, 2024 20:13
@yaugenst-flex yaugenst-flex changed the base branch from pre/2.8 to develop July 4, 2024 20:13
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-interp branch from c96525a to ff75702 Compare July 4, 2024 20:16
@yaugenst-flex yaugenst-flex marked this pull request as ready for review July 4, 2024 20:18
tylerflex
tylerflex approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 👍 feel like this is ready once the notebook issue is figured out. thanks Yannick!

tests/test_components/test_autograd.py Show resolved Hide resolved
tests/test_plugins/autograd/test_functions.py Show resolved Hide resolved
tidy3d/components/base.py Show resolved Hide resolved
tidy3d/components/data/data_array.py Show resolved Hide resolved
@tylerflex tylerflex added the .1 label Jul 5, 2024
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-interp branch 2 times, most recently from a1ef16c to a918411 Compare July 6, 2024 11:56
@yaugenst-flex yaugenst-flex force-pushed the yaugenst-flex/autograd-interp branch from a918411 to 1fe8638 Compare July 6, 2024 11:58
@yaugenst-flex
Copy link
Contributor Author

Metalens notebook is passing, so this should be ready to go @tylerflex @momchil-flex

@tylerflex
Copy link
Collaborator

Looks good to me! Feel free to merge when everyone approves. Could you also add a PR for the autograd metalens notebook?

@tylerflex
Copy link
Collaborator

and perhaps change existing autograd notebooks to use get_intensity where applicable.

(quickstart, metallic antenna).

@yaugenst-flex yaugenst-flex mentioned this pull request Jul 8, 2024
Merged
@tylerflex
Copy link
Collaborator

@dmarek-flex any last comments / suggestions before we merge this?

dmarek-flex
dmarek-flex approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@dmarek-flex dmarek-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tylerflex tylerflex merged commit fefb97d into develop Jul 8, 2024
16 checks passed
@tylerflex tylerflex deleted the yaugenst-flex/autograd-interp branch July 8, 2024 18:59
@yaugenst-flex yaugenst-flex mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@dmarek-flex dmarek-flex dmarek-flex approved these changes

Assignees

@yaugenst-flex yaugenst-flex

Labels
2.7 will go into version 2.7.* .1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yaugenst-flex @tylerflex @dmarek-flex