Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Include invdes module in API docs #1765

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

daquinteroflex
Copy link
Collaborator

@daquinteroflex daquinteroflex commented Jun 14, 2024

Pretty urgent pre-2.7 release patch to include the invdes module on the API docs. Possibly my bad in not catching this in review sorry!

Doing a thorough upgrade on docs #1745 and caught this in time

Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For docs, things are not that urgent I guess since even if we had released, we could always update or latest build with this fix.

Note that you should remove the submodule update.

@daquinteroflex
Copy link
Collaborator Author

daquinteroflex commented Jun 14, 2024

Sounds good! I've just updated the submodule state to the last tidy3d-notebooks/develop for the tests to pass too

@momchil-flex momchil-flex merged commit 8787330 into develop Jun 14, 2024
16 checks passed
@momchil-flex momchil-flex deleted the dario/patch_invdes_docs branch June 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants