Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lossless Green2008 cSi and modify default SiO2 in material_library #1738

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Add lossless Green2008 cSi and modify default SiO2 in material_library #1738

merged 1 commit into from
Jun 5, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

Address #1529:

  • Switch the default variant from Horiba to Palik_Lossess for SiO2;
  • Add Lossless Green2008 for cSi. The default remains unchanged as only Green2008 covers visible spectrum

@weiliangjin2021 weiliangjin2021 added the 2.7 will go into version 2.7.* label Jun 3, 2024
momchil-flex
momchil-flex approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@momchil-flex momchil-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a tiny change and then merge.

tidy3d/material_library/material_library.py Outdated Show resolved Hide resolved
@weiliangjin2021 weiliangjin2021 merged commit 4533274 into pre/2.7 Jun 5, 2024
16 checks passed
@weiliangjin2021 weiliangjin2021 deleted the weiliang/material_updates branch June 5, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerflex tylerflex tylerflex approved these changes

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees
No one assigned
Labels
2.7 will go into version 2.7.*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weiliangjin2021 @momchil-flex @tylerflex