improved test coverage of microstrip plugin #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiliangjin2021
approved these changes
May 23, 2024
dmarek-flex
force-pushed
the
dmarek/improve_microwave_model_coverage
branch
from
350f7dc
to
71933c3
Compare
tylerflex
approved these changes
May 24, 2024
| @@ -1,5 +1,9 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
can you add a module level docstring and docstrings for the individual tests?
Also you may want to run ruff tests/test_plugins/test_microwave.py as we'll start ruffing test files from 2.7.0
There was a problem hiding this comment.
careful about ruffing the whole test directory or you'll get a lot of changes / errors, many of which are already covered #1707
dmarek-flex
force-pushed
the
dmarek/improve_microwave_model_coverage
branch
from
71933c3
to
1b80432
Compare
|
I think we can merge this in @dmarek-flex ? |
I just need to add docstrings to the individual tests, then I will merge. |
|
sounds good, just be sure to squash to 1 commit, thanks! |
dmarek-flex
force-pushed
the
dmarek/improve_microwave_model_coverage
branch
from
1b80432
to
7aec6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding some unit tests and removing deprecated typing
the models part is at 100% now