Validate Medium2D components to be either both PEC or non-PEC #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weiliangjin2021 submodule needs updating I think and then we can merge |
dmarek-flex
approved these changes
May 24, 2024
|
Just make sure to squash commits too, thanks! |
weiliangjin2021
force-pushed
the
weiliang/validate_medium2d
branch
from
267e536
to
93ff0df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle, we should warn in AnisotropicMedium if the 3 components are not simultaneously PEC or non-PEC. This is because the solver will just convert the anisotropic medium to PECMedium if any of its component is PEC. But since hopefully it is unlikely to be used directly in AnistropicMedium, let's just add a validator in Medium2D.