Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle edge case when estimate_cost() returns None for jobs in Batch #1673

Merged
merged 1 commit into from
May 6, 2024

Conversation

tylerflex
Copy link
Collaborator

not sure a changelog item is needed because this never came up before I refactored in #1630

Comes up now when some of the tasks error.

Copy link
Collaborator

@lucas-flexcompute lucas-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this issue a warning?

@tylerflex
Copy link
Collaborator Author

Should this issue a warning?

Setting batch_cost to None will trigger a log explaining that the batch could not be calculated.

console.log("Could not get estimated batch cost!")

Think this is sufficient?

@tylerflex tylerflex merged commit ec571fa into pre/2.7 May 6, 2024
16 checks passed
@tylerflex tylerflex deleted the tyler/fix/batch_estimate_None branch May 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants