proper error when computing poynting vector of jax-traced field data #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "Adjoint support for differentiation with respect to Poynting vector not available." | ||
| " If you would like to request this feature for future versions, " | ||
| "please make an issue on the tidy3d front end repository " | ||
| "'https://github.com/flexcompute/tidy3d/issues'." |
There was a problem hiding this comment.
How about we make the issue ourselves and we just say here that it is not yet available?
There was a problem hiding this comment.
ok, just removed the last three lines in this message
There was a problem hiding this comment.
and made a new issue for this.
tylerflex
force-pushed
the
tyler/adjoint/raise_poynting
branch
2 times, most recently
from
eb0bb3f
to
2dcc321
Compare
tylerflex
force-pushed
the
tyler/adjoint/raise_poynting
branch
from
2dcc321
to
248150c
Compare
|
@momchil-flex while you're merging stuff, I just rebased this for 2.7 so should be all set. |
|
Great, thanks, I wanted to merge it yeah but I was too lazy to fix myself. :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1531