Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero thickness for volumetric equivalence of 2D material #1555

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Zero thickness for volumetric equivalence of 2D material #1555

merged 1 commit into from
Apr 24, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

Different subclass for volumeric equivalence of Medium2D

@weiliangjin2021 weiliangjin2021 marked this pull request as draft March 15, 2024 23:37
@weiliangjin2021 weiliangjin2021 added the awaiting backend not to be merged as backend is not finalized label Mar 15, 2024
@dmarek-flex
Copy link
Contributor

Looks good, but I think I will wait to approve until I try it with the backend changes.

dmarek-flex
dmarek-flex reviewed Mar 26, 2024
View reviewed changes
tidy3d/components/medium.py Outdated Show resolved Hide resolved
tidy3d/components/simulation.py Outdated Show resolved Hide resolved
@weiliangjin2021 weiliangjin2021 marked this pull request as ready for review March 26, 2024 19:12
tylerflex
tylerflex approved these changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@tylerflex tylerflex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. just a few comments

  • Do we want to allow AnisotropicMediumFromMedium2D to be imported form tidy3d? if so, import it into __init__.py.
  • Please add changelog line, if you think it warrants it.
    Thanks!

@weiliangjin2021 weiliangjin2021 force-pushed the weiliang/2dmaterial branch 2 times, most recently from 9c2631d to 7748696 Compare April 23, 2024 23:43
@weiliangjin2021
Zero thickness for volumetric equivalence of 2D material
8d3ea16 
Different subclass for volumeric equivalence of Medium2D

Filter out zero coefficient poles in volumetric equivalent with zero size 2d materials: there is no need to perform intersections with previously added 2d materials in _volumetric_structures_grid
@weiliangjin2021 weiliangjin2021 merged commit 4180e20 into pre/2.7 Apr 24, 2024
16 checks passed
@weiliangjin2021 weiliangjin2021 deleted the weiliang/2dmaterial branch April 24, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmarek-flex dmarek-flex dmarek-flex approved these changes

@caseyflex caseyflex caseyflex approved these changes

@tylerflex tylerflex tylerflex approved these changes

Assignees
No one assigned
Labels
awaiting backend not to be merged as backend is not finalized
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weiliangjin2021 @dmarek-flex @tylerflex @caseyflex