Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PolySlab intersections when bounds contain inf #1547

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix PolySlab intersections when bounds contain inf #1547

merged 1 commit into from
Mar 15, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

Resolves #1539

Two main changes:

  • In computing center_axis, replace inf with LARGE_NUMBER;
  • Use .finite_length_axis instead of .length_axis .

@momchil-flex momchil-flex merged commit 5d1927c into pre/2.7 Mar 15, 2024
12 of 13 checks passed
@momchil-flex momchil-flex deleted the weiliang/polyslab branch March 15, 2024 17:24
@momchil-flex momchil-flex mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momchil-flex momchil-flex momchil-flex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weiliangjin2021 @momchil-flex