FEAT: Compute characteristic impedance from fields #1542
Conversation
|
Agree that we should have a RF plugin. The other related issue is that we can have a wave port (which I think is the same as the current mode source, but slight difference in s-matrix parameter extraction?) |
There was a problem hiding this comment.
Looks much cleaner now! In "path_integrals.py", there are duplicate codes in "normal_axis" and "remaining_axes". I wonder if you can define an abstract class that has those two methods, and then AxisAlignedPathIntegral and CurrentIntegralAA subclass from this class.
dmarek-flex
force-pushed
the
dmarek/impedance_from_fields
branch
3 times, most recently
from
ea052ed
to
af968e4
Compare
dmarek-flex
force-pushed
the
dmarek/impedance_from_fields
branch
from
af968e4
to
39dbf98
Compare
dmarek-flex
force-pushed
the
dmarek/impedance_from_fields
branch
from
39dbf98
to
06306a1
Compare
|
I updated the changelog for this PR, but I was a little confused by the state of the versioning. It seems like LumpedElements have been added in 2.6, but that is not the case. |
Yeah, it's messed up. I suppose it'll be cleaned up upon release. For now, you can edit near the part that should go pre/2.7. E.g. the Added section should go pre/2.7; There are 2 Changed section, the former one should go pre/2.7. |
dmarek-flex
force-pushed
the
dmarek/impedance_from_fields
branch
from
06306a1
to
e5a0f27
Compare
There was a problem hiding this comment.
Thanks @dmarek-flex ! Looks really good overall. This will be a great addition.
My comments are pretty minor but apply a bit globally at times so just make sure you address them not only where I commented. eg. the quotes, capitalization, and other formatting.
I do wonder if we need to build some more advanced DataArray handling for your applications into our main package, let me know if you have any thoughts on that.
|
@dmarek-flex will there be a notebook tutorial to go along with this? |
Yes, that would be a good idea. I have added an issue for the planned microwave notebooks to help with tracking. |
dmarek-flex
force-pushed
the
dmarek/impedance_from_fields
branch
from
ce9b7db
to
c1cb790
Compare
…rent/impedance reused path integrals in smatrix plugin
dmarek-flex
force-pushed
the
dmarek/impedance_from_fields
branch
from
c1cb790
to
e33f14d
Compare
Addresses Issue 517. Most of computations are done, now it is just a question of the best way to expose this functionality to users. I wonder if @weiliangjin2021 or @tylerflex have any input on whether we should start a "microwave" plugin that includes functionality that might not be commonly used in photonics. I mention that because it would be very easy to add time domain Voltage and Current monitors now.
Some tasks remaining: