Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uniaxial medium lithium niobate to material library #1484

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

Resolves #1413

The doc page for LiNiO3:
Screenshot from 2024-02-20 18-02-52

One question to @daquinteroflex: now I need to manually run python generate_doc.py to update material_library.rst, so that the doc page can include updated material library. Is that the expected behavior?

Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weiliangjin2021 . This is a very nice addition. We can update this notebook to use the material library option later.

@daquinteroflex
Copy link
Collaborator

Ahh thanks for the catch Weiliang! What I will do is in the next docs PR, every time you run poetry run tidy3d develop build-docs, it automatically builds the material library just for the sake of convenience - or see if I can hook it into the sphinx build process.

@tylerflex tylerflex added the 2.7 will go into version 2.7.* label Feb 22, 2024
@momchil-flex momchil-flex added 2.6 and removed 2.7 will go into version 2.7.* labels Feb 22, 2024
@weiliangjin2021 weiliangjin2021 changed the base branch from pre/2.6 to pre/2.7 February 23, 2024 17:08
@weiliangjin2021 weiliangjin2021 force-pushed the weiliang/uniaxial branch 2 times, most recently from 63d8af2 to 914d5a6 Compare February 23, 2024 17:12
@weiliangjin2021 weiliangjin2021 merged commit 0c86ddc into pre/2.7 Feb 23, 2024
16 checks passed
@weiliangjin2021 weiliangjin2021 deleted the weiliang/uniaxial branch February 23, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants