-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope pending host profile rebuilds #23772
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23772 +/- ##
=======================================
Coverage 63.17% 63.18%
=======================================
Files 1559 1559
Lines 148191 148259 +68
Branches 3722 3722
=======================================
+ Hits 93617 93674 +57
- Misses 47180 47188 +8
- Partials 7394 7397 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you add a QA Testplan for this issue? We should manually test this logic to make sure we didn't introduce new issues.
@@ -189,6 +189,7 @@ the way that the Fleet server works. | |||
if config.MysqlReadReplica.Address != "" { | |||
opts = append(opts, mysql.Replica(&config.MysqlReadReplica)) | |||
} | |||
// NOTE this will disable OTEL/APM interceptor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
#21338
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)Added/updated testsQA Testplan:
osquery-perf
and add them to a team