Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope pending host profile rebuilds #23772

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Nov 13, 2024

#21338

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

QA Testplan:

  • For mac and windows scale:
    • Create ~20k MDM-enrolled hosts in 1k batches (for performance reasons) using osquery-perf and add them to a team
    • Add 10-15 profiles to that team
    • Try adding and removing profiles in various states of verification/enrollment
  • For profile application:
    • Create a team with a couple of real devices
    • Try applying profiles in the same way, make sure they get queued, installed, and removed correctly

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 99.09910% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.18%. Comparing base (035df55) to head (73b5015).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
server/service/apple_mdm.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23772   +/-   ##
=======================================
  Coverage   63.17%   63.18%           
=======================================
  Files        1559     1559           
  Lines      148191   148259   +68     
  Branches     3722     3722           
=======================================
+ Hits        93617    93674   +57     
- Misses      47180    47188    +8     
- Partials     7394     7397    +3     
Flag Coverage Δ
backend 64.02% <99.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo changed the title Try to scope pending host profiles to specific profiles Scope pending host profile queries Nov 14, 2024
@dantecatalfamo dantecatalfamo changed the title Scope pending host profile queries Scope pending host profile rebuilds Nov 14, 2024
@dantecatalfamo dantecatalfamo marked this pull request as ready for review November 14, 2024 22:00
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner November 14, 2024 22:00
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a QA Testplan for this issue? We should manually test this logic to make sure we didn't introduce new issues.

@@ -189,6 +189,7 @@ the way that the Fleet server works.
if config.MysqlReadReplica.Address != "" {
opts = append(opts, mysql.Replica(&config.MysqlReadReplica))
}
// NOTE this will disable OTEL/APM interceptor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dantecatalfamo dantecatalfamo merged commit 167e2e3 into main Nov 15, 2024
25 checks passed
@dantecatalfamo dantecatalfamo deleted the scope-rebuild-pending-profiles branch November 15, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants