Add `team_identifier` to macOS software #23766

lucasmrod · 2024-11-13T16:15:35Z

Changes to add team_identifier signing information to macOS applications on the /api/latest/fleet/hosts/:id/software API endpoint.

Docs: #23743

for #23858

codecov · 2024-11-15T14:35:57Z

Codecov Report

Attention: Patch coverage is 72.63158% with 26 lines in your changes missing coverage. Please review.

Project coverage is 63.17%. Comparing base (4f03956) to head (022892d).
Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
server/service/osquery_utils/queries.go	30.76%	17 Missing and 1 partial ⚠️
...9_AddTeamIdentifierToHostSoftwareInstalledPaths.go	54.54%	4 Missing and 1 partial ⚠️
server/service/osquery.go	50.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #23766      +/-   ##
==========================================
+ Coverage   63.15%   63.17%   +0.01%     
==========================================
  Files        1559     1560       +1     
  Lines      148227   148295      +68     
  Branches     3722     3722              
==========================================
+ Hits        93618    93683      +65     
- Misses      47207    47211       +4     
+ Partials     7402     7401       -1

Flag	Coverage Δ
backend	`64.01% <72.63%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

orbit/pkg/table/codesign/codesign_darwin.go

iansltx

Some of this could be cleaner, but you've marked those items as TODO and given time constraints that's fair enough. Had a few questions/minor tweaks, but this makes sense to me.

docs/Contributing/Understanding-host-vitals.md

orbit/pkg/table/codesign/codesign_darwin.go

schema/osquery_fleet_schema.json

schema/tables/codesign.yml

server/datastore/mysql/software.go

server/datastore/mysql/software_test.go

server/fleet/datastore.go

server/service/integration_core_test.go

Co-authored-by: Tim Lee <[email protected]>

Co-authored-by: Ian Littman <[email protected]>

iansltx

LGTM;; thanks for addressing the feedback/questions!

I missed to add support for load testing in: #23766.

Changes to add `team_identifier` signing information to macOS applications on the `/api/latest/fleet/hosts/:id/software` API endpoint. Docs: #23743 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes - [X] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [X] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [X] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ X Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [X] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [X] Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (`runtime.GOOS`). - [X] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [X] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)). --------- Co-authored-by: Tim Lee <[email protected]> Co-authored-by: Ian Littman <[email protected]>

I missed to add support for load testing in: #23766.

Changes to add `team_identifier` signing information to macOS applications on the `/api/latest/fleet/hosts/:id/software` API endpoint. Docs: #23743 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes - [X] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [X] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [X] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ X Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [X] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [X] Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (`runtime.GOOS`). - [X] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [X] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)). --------- Co-authored-by: Tim Lee <[email protected]> Co-authored-by: Ian Littman <[email protected]>

I missed to add support for load testing in: #23766.

Cherry pick PR #23766 into RC v4.60.0 Co-authored-by: Tim Lee <[email protected]> Co-authored-by: Ian Littman <[email protected]>

Changes to add `team_identifier` signing information to macOS applications on the `/api/latest/fleet/hosts/:id/software` API endpoint. Docs: #23743 - [X] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [X] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [X] Added/updated tests - [X] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes - [X] If database migrations are included, checked table schema to confirm autoupdate - For database migrations: - [X] Checked schema for all modified table for columns that will auto-update timestamps during migration. - [X] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ X Ensured the correct collation is explicitly set for character columns (`COLLATE utf8mb4_unicode_ci`). - [X] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [X] Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (`runtime.GOOS`). - [X] Manual QA must be performed in the three main OSs, macOS, Windows and Linux. - [X] Auto-update manual QA, from released version of component to new version (see [tools/tuf/test](../tools/tuf/test/README.md)). --------- Co-authored-by: Tim Lee <[email protected]> Co-authored-by: Ian Littman <[email protected]>

lucasmrod assigned mostlikelee Nov 13, 2024

lucasmrod requested review from eashaw, rachaelshaw and a team as code owners November 13, 2024 16:15

lucasmrod temporarily deployed to Docker Hub November 13, 2024 16:15 — with GitHub Actions Inactive

rachaelshaw previously approved these changes Nov 13, 2024

View reviewed changes

lucasmrod dismissed rachaelshaw’s stale review via 32c0f90 November 13, 2024 17:04

lucasmrod force-pushed the 8750-team_identifier branch from 32c0f90 to 973b504 Compare November 13, 2024 17:29

lucasmrod temporarily deployed to Docker Hub November 13, 2024 17:29 — with GitHub Actions Inactive

eashaw previously approved these changes Nov 13, 2024

View reviewed changes

lucasmrod added 3 commits November 15, 2024 08:59

Add team_identifier to macOS software

56a937c

Fix tests

3231292

Move team identifier from software to host/software API

13ffe36

lucasmrod dismissed eashaw’s stale review via 13ffe36 November 15, 2024 13:40

lucasmrod force-pushed the 8750-team_identifier branch from 973b504 to 13ffe36 Compare November 15, 2024 13:40

lucasmrod temporarily deployed to Docker Hub November 15, 2024 13:40 — with GitHub Actions Inactive

lucasmrod added 2 commits November 15, 2024 11:04

Amend changes file

cc4c36a

Fix TestDirectIngestSoftware test

0b099f5

lucasmrod temporarily deployed to Docker Hub November 15, 2024 14:16 — with GitHub Actions Inactive

Add comments and truncate team identifier

c598e84

lucasmrod temporarily deployed to Docker Hub November 15, 2024 14:58 — with GitHub Actions Inactive

Added orbit changes

e6a2c5b

lucasmrod temporarily deployed to Docker Hub November 15, 2024 15:11 — with GitHub Actions Inactive

lucasmrod assigned iansltx and unassigned mostlikelee Nov 15, 2024

mostlikelee reviewed Nov 15, 2024

View reviewed changes

orbit/pkg/table/codesign/codesign_darwin.go Outdated Show resolved Hide resolved

iansltx reviewed Nov 15, 2024

View reviewed changes

Update orbit/pkg/table/codesign/codesign_darwin.go

03d3926

Co-authored-by: Tim Lee <[email protected]>

lucasmrod had a problem deploying to Docker Hub November 15, 2024 15:52 — with GitHub Actions Error

Update orbit/pkg/table/codesign/codesign_darwin.go

c2078e8

Co-authored-by: Ian Littman <[email protected]>

lucasmrod had a problem deploying to Docker Hub November 15, 2024 15:52 — with GitHub Actions Error

Update schema/tables/codesign.yml

ae15d88

Co-authored-by: Ian Littman <[email protected]>

lucasmrod temporarily deployed to Docker Hub November 15, 2024 15:53 — with GitHub Actions Inactive

Address code review comments

9d215b9

lucasmrod had a problem deploying to Docker Hub November 15, 2024 16:05 — with GitHub Actions Error

Update server/service/integration_core_test.go

022892d

Co-authored-by: Ian Littman <[email protected]>

lucasmrod temporarily deployed to Docker Hub November 15, 2024 16:06 — with GitHub Actions Inactive

iansltx approved these changes Nov 15, 2024

View reviewed changes

rachaelshaw approved these changes Nov 15, 2024

View reviewed changes

rachaelshaw requested a review from eashaw November 15, 2024 17:11

eashaw approved these changes Nov 15, 2024

View reviewed changes

lucasmrod merged commit 4b4fc97 into main Nov 15, 2024
37 checks passed

lucasmrod deleted the 8750-team_identifier branch November 15, 2024 17:17

lucasmrod mentioned this pull request Nov 15, 2024

Adding support for codesign table on osquery-perf #23855

Merged

lucasmrod added a commit that referenced this pull request Nov 15, 2024

Adding support for codesign table on osquery-perf (#23855)

351fb36

I missed to add support for load testing in: #23766.

lukeheath modified the milestone: 4.59.1 Nov 15, 2024

lucasmrod added a commit that referenced this pull request Nov 15, 2024

Adding support for codesign table on osquery-perf (#23855)

9a2b6d5

I missed to add support for load testing in: #23766.

lukeheath pushed a commit that referenced this pull request Nov 15, 2024

Adding support for codesign table on osquery-perf (#23855)

f8206db

I missed to add support for load testing in: #23766.

lucasmrod mentioned this pull request Nov 15, 2024

Cherry pick PR #23766 into RC v4.60.0 #23865

Merged

lucasmrod added a commit that referenced this pull request Nov 15, 2024

Adding support for codesign table on osquery-perf (#23855)

108edab

I missed to add support for load testing in: #23766.

iansltx added a commit that referenced this pull request Nov 15, 2024

Cherry pick PR #23766 into RC v4.60.0 (#23865)

468a5b8

Cherry pick PR #23766 into RC v4.60.0 Co-authored-by: Tim Lee <[email protected]> Co-authored-by: Ian Littman <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `team_identifier` to macOS software #23766

Add `team_identifier` to macOS software #23766

lucasmrod commented Nov 13, 2024 •

edited by lukeheath

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading

iansltx left a comment

iansltx left a comment

Add team_identifier to macOS software #23766

Add team_identifier to macOS software #23766

Conversation

lucasmrod commented Nov 13, 2024 • edited by lukeheath Loading

codecov bot commented Nov 15, 2024 • edited Loading

Codecov Report

iansltx left a comment

Choose a reason for hiding this comment

iansltx left a comment

Choose a reason for hiding this comment

Add `team_identifier` to macOS software #23766

Add `team_identifier` to macOS software #23766

lucasmrod commented Nov 13, 2024 •

edited by lukeheath

Loading

codecov bot commented Nov 15, 2024 •

edited

Loading