-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux disk encryption: frontend changes, backend missing private key errors, remove disk encryption endpoints dependence on MDM being enabled #23714
Draft
jacobshandling
wants to merge
43
commits into
22074-linux-encryption
Choose a base branch
from
22702-LUKS-frontend
base: 22074-linux-encryption
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Linux column to Disk encryption table * Add "linux" to type for expected platforms with disk encryption * Widen capabilities of `SectionHeader` to include: * Vertically aligned title/subtitle * Optional grey subtitle text coloring
jacobshandling
temporarily deployed
to
Docker Hub
November 12, 2024 02:55
— with
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
November 12, 2024 17:50
— with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 22074-linux-encryption #23714 +/- ##
==========================================================
- Coverage 63.17% 63.16% -0.02%
==========================================================
Files 1559 1561 +2
Lines 148227 148305 +78
Branches 3722 3754 +32
==========================================================
+ Hits 93642 93676 +34
- Misses 47188 47232 +44
Partials 7397 7397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Allows rendering of Disk Encryption section even when MDM is not enabled
jacobshandling
temporarily deployed
to
Docker Hub
November 12, 2024 22:21
— with
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
November 13, 2024 00:16
— with
GitHub Actions
Inactive
jacobshandling
changed the title
UI – Linux disk encryption
Linux disk encryption: frontend changes, backend error on update DE setting with missing private key
Nov 13, 2024
jacobshandling
temporarily deployed
to
Docker Hub
November 13, 2024 00:42
— with
GitHub Actions
Inactive
…23757) > Related issue: #23200 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
jacobshandling
requested review from
Sampfluger88 and
rachaelshaw
as code owners
November 14, 2024 23:59
jacobshandling
temporarily deployed
to
Docker Hub
November 14, 2024 23:59
— with
GitHub Actions
Inactive
jacobshandling
dismissed
RachelElysia’s stale review
November 15, 2024 00:11
The base branch was changed.
jacobshandling
removed request for
lukeheath,
rachaelshaw,
eashaw,
Sampfluger88 and
zayhanlon
November 15, 2024 00:14
jacobshandling
temporarily deployed
to
Docker Hub
November 15, 2024 17:57
— with
GitHub Actions
Inactive
jacobshandling
temporarily deployed
to
Docker Hub
November 16, 2024 00:53
— with
GitHub Actions
Inactive
iansltx
force-pushed
the
22074-linux-encryption
branch
from
November 16, 2024 22:13
e27e916
to
48b992e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22702, #23713, #23756, #23747, and #23876
-Note that much of this code as is will render as expected only once integrated with the backend or if manipulated manually for testing purposes
Frontend:
Create key
CreateLinuxKeyModal
to inform user of next steps after clickingCreate key
SectionHeader
component, apply to new UI-Other TODO:
Backend:
For "No team" and teams, error when trying to update disk encryption enabled while no server private key is present.
Remove requiring mdm to be enabled from 3 endpoint operations
Changes file added for user-visible changes in
changes/
Added/updated tests
Manual QA for all new/changed functionality