FOGL-7349 Add persistence of SQLiteInMemory between executions #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Riddoch <[email protected]>
Signed-off-by: Mark Riddoch <[email protected]>
pintomax
previously approved these changes
Aug 23, 2023
Signed-off-by: Mark Riddoch <[email protected]>
pintomax
previously approved these changes
Aug 23, 2023
RVerhoeff
reviewed
Aug 23, 2023
| { | ||
| rc = sqlite3_backup_step(backup, -1); | ||
| (void)sqlite3_backup_finish(backup); | ||
| Logger::getLogger()->info("Persisted data from in memory database to %s", pathname.c_str()); |
There was a problem hiding this comment.
Perhaps be consistent with the dash in "in-memory?" This message is without; the messages below have the dash. This occurs in several places in the changed files.
RVerhoeff
reviewed
Aug 23, 2023
| "validity": "persist == \"true\"" | ||
| }, | ||
| "persist" : { | ||
| "description" : "Enable the persistance of the in memory database between executions", |
There was a problem hiding this comment.
Typo: persistance -> persistence
RVerhoeff
reviewed
Aug 23, 2023
docs/tuning_fledge.rst
Outdated
|
|
||
| - **Persist File**: This defines the name of the file to which the in-memory database willbe persisted. |
Signed-off-by: Mark Riddoch <[email protected]>
pintomax
approved these changes
Aug 24, 2023
RVerhoeff
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.