fix: make horizontal repetition CRS dependent #1978

monsieurtanuki · 2024-10-16T07:53:05Z

What

cf. [BUG] unbounded horizontal scroll breaks most tile grids #1976
The recent changes feat: unbounded horizontal scroll #1948 enhanced world replications.
Unfortunately, in less straightforward examples than webmercator the world replications don't have much sense. Which provoked display bugs.
Now, we can enjoy both webmercator with world replications, and other projections without world replications.
cc @arneke

Files

New file:

epsg3006_crs.dart: new example around EPSG3006, needed for tests

Impacted files:

camera.dart: special case around replicatesWorldLongitude
crs.dart: new bool getter replicatesWorldLongitude
main.dart: added EPSG3006 example
map_interactive_viewer.dart: special case around replicatesWorldLongitude
menu_drawer.dart: added EPSG3006 example
tile_coordinates.dart: moved code to new class TileCoordinatesSimplifier
tile_image_manager.dart: now using a TileCoordinatesSimplifier for more flexibility
tile_image_view.dart: now using a TileCoordinatesSimplifier for more flexibility
tile_layer.dart: special case around replicatesWorldLongitude
tile_range.dart: special case around replicatesWorldLongitude

New file: * `epsg3006_crs.dart`: new example around EPSG3006, needed for tests Impacted files: * `camera.dart`: special case around `replicatesWorldLongitude` * `crs.dart`: new `bool` getter `replicatesWorldLongitude` * `main.dart`: added EPSG3006 example * `map_interactive_viewer.dart`: special case around `replicatesWorldLongitude` * `menu_drawer.dart`: added EPSG3006 example * `tile_coordinates.dart`: moved code to new class `TileCoordinatesSimplifier` * `tile_image_manager.dart`: now using a `TileCoordinatesSimplifier` for more flexibility * `tile_image_view.dart`: now using a `TileCoordinatesSimplifier` for more flexibility * `tile_layer.dart`: special case around `replicatesWorldLongitude` * `tile_range.dart`: special case around `replicatesWorldLongitude`

arneke · 2024-10-17T12:09:48Z

This branch works well in my application.

Still think the 1 << z is a bit problematic. Does https://demo.fleaflet.dev/crs_epsg4326 work for you locally ? (that is a grid with two tiles at z = 0)

monsieurtanuki · 2024-10-17T13:07:35Z

This branch works well in my application.

Cool!

Still think the 1 << z is a bit problematic. Does https://demo.fleaflet.dev/crs_epsg4326 work for you locally ? (that is a grid with two tiles at z = 0)

@arneke You're right: I've just fixed that. Thank you for your meticulous review!

JaffaKetchup

Sorry for the long wait, had a busy week!

lib/src/layer/tile_layer/tile_coordinates.dart

JaffaKetchup

(Sorry for the wait, I've had a hugely busy few weeks!)

I think I'm OK with this, but would appreciate a review from someone else!

monsieurtanuki · 2024-11-13T16:49:32Z

Thank you @JaffaKetchup for your review!
I'm open to new reviews and new suggestions.

josxha

I have the feeling that the fling animation has stutters when using a map with longitude repetition. Most notifable when crossing the -180/180 longitude. Could anyone check if it happens to them as well?

josxha · 2024-11-16T08:03:32Z

example/lib/pages/epsg3006_crs.dart

+                  urlTemplate:
+                      'https://maps.trafikinfo.trafikverket.se/MapService/wmts.axd/BakgrundskartaNorden.gpkg?layer=Background&style=default&tilematrixset=Default.256.3006&Service=WMTS&Request=GetTile&Version=1.0.0&Format=image%2Fpng&TileMatrix={z}&TileCol={x}&TileRow={y}')


What are the usage policy for this tile source? Source attribution would be a good think, too.

The tile source has long loading times for me. When I run the app on windows the tiles don't load but I got an exception. Not sure if this only happens on my machine though.

======== Exception caught by image resource service ================================================ The following HandshakeException was thrown resolving an image codec: Handshake error in client (OS Error: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393)) When the exception was thrown, this was the stack: #0 _SecureFilterImpl._handshake (dart:io-patch/secure_socket_patch.dart:99:46) #1 _SecureFilterImpl.handshake (dart:io-patch/secure_socket_patch.dart:143:25) #2 _RawSecureSocket._secureHandshake (dart:io/secure_socket.dart:920:54) #3 _RawSecureSocket._tryFilter (dart:io/secure_socket.dart:1049:19) <asynchronous suspension> #4 _RawSecureSocket._secureHandshake (dart:io/secure_socket.dart:928:9) <asynchronous suspension> #5 _RawSecureSocket._tryFilter (dart:io/secure_socket.dart:1049:13) <asynchronous suspension> URL: https://maps.trafikinfo.trafikverket.se/MapService/wmts.axd/BakgrundskartaNorden.gpkg?layer=Background&style=default&tilematrixset=Default.256.3006&Service=WMTS&Request=GetTile&Version=1.0.0&Format=image%2Fpng&TileMatrix=13&TileCol=466563&TileRow=111610 Fallback URL: null Current provider: MapNetworkImageProvider() ==================================================================================================== flutter: HandshakeException: Handshake error in client (OS Error: flutter: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393)) flutter: HandshakeException: Handshake error in client (OS Error: flutter: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393)) flutter: HandshakeException: Handshake error in client (OS Error: flutter: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393)) flutter: HandshakeException: Handshake error in client (OS Error: flutter: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393)) flutter: HandshakeException: Handshake error in client (OS Error: flutter: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393)) flutter: HandshakeException: Handshake error in client (OS Error: flutter: CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate(../../../flutter/third_party/boringssl/src/ssl/handshake.cc:393))

What are the usage policy for this tile source? Source attribution would be a good think, too.

cc @arneke

Regarding CERTIFICATE errors, I've never experienced one, working on an Android emulator working on Windows.

There's nothing published (I mention this at the top of the example in #1976). I included it to make it easy to reproduce the bug, was not really expecting this to end up on the Flutter Map website.

I can see if I can make a public service with dummy data available at some point, but not immediately and no guarantees about uptime or longevity.

@arneke My initial point was to be able to test the fixes, for instance with the "3006" projection.
Any "non web-mercator" would have done the trick.
I've just removed "your 3006" from the PR.

lib/src/layer/tile_layer/tile_coordinates.dart

Impacted files: * tile_coordinates.dart: renamed as TileCoordinatesResolver and made const * tile_image_manager.dart: removed the immutable metatag; used a setter and refactored * tile_image_view.dart: refactored with a non null resolver * tile_layer.dart: using a setter instead

monsieurtanuki · 2024-11-16T16:54:05Z

@JaffaKetchup @josxha Actually TileCoordinatesSimplifier isn't only used in TileImageManager, but also in TileImageView.
That said, removing @immutable enables me to code as I would have in a first approach, cf. latest push.

monsieurtanuki · 2024-11-16T16:58:24Z

I have the feeling that the fling animation has stutters when using a map with longitude repetition. Most notifable when crossing the -180/180 longitude. Could anyone check if it happens to them as well?

I suspect that my latest push made things slightly faster, with const classes and fields. Not a big user of flings, but haven't noticed anything problematic.

josxha · 2024-11-16T17:59:49Z

Do you know why the map is offset between zoom level 1 and 2?
I've seen some thin black lines shimmering through from the custom tile builder. Do you know if it is related to this pr?

recoding.mp4

josxha

Removing the example page, solves my open points. 😄
Looks good! Thanks for the contribution.

monsieurtanuki · 2024-11-17T14:08:58Z

@JaffaKetchup @josxha Thank you for your reviews and comments!

Still, there seems to be an issue with the "Build Android Example App" CI/CD. A bit cryptic to me: maybe the gradle version, maybe the android ndk version.

monsieurtanuki added 2 commits October 16, 2024 09:48

typo fix

1ec9e71

monsieurtanuki mentioned this pull request Oct 16, 2024

[BUG] unbounded horizontal scroll breaks most tile grids #1976

Open

functional fix

7e61d4b

JaffaKetchup requested review from mootw, JaffaKetchup and josxha and removed request for mootw and JaffaKetchup October 21, 2024 15:08

JaffaKetchup requested changes Oct 21, 2024

View reviewed changes

lib/src/layer/tile_layer/tile_coordinates.dart Outdated Show resolved Hide resolved

JaffaKetchup changed the title ~~fix: now works for crs with world replication or not~~ fix: make horizontal repetition CRS dependent Oct 21, 2024

JaffaKetchup linked an issue Oct 21, 2024 that may be closed by this pull request

[BUG] unbounded horizontal scroll breaks most tile grids #1976

Open

JaffaKetchup approved these changes Nov 12, 2024

View reviewed changes

JaffaKetchup requested review from ibrierley and TesteurManiak November 12, 2024 20:22

josxha reviewed Nov 16, 2024

View reviewed changes

monsieurtanuki added 2 commits November 16, 2024 17:41

removed "3006"

e2e1e26

josxha approved these changes Nov 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make horizontal repetition CRS dependent #1978

fix: make horizontal repetition CRS dependent #1978

monsieurtanuki commented Oct 16, 2024

arneke commented Oct 17, 2024

monsieurtanuki commented Oct 17, 2024

JaffaKetchup left a comment

JaffaKetchup left a comment

monsieurtanuki commented Nov 13, 2024

josxha left a comment

josxha Nov 16, 2024

monsieurtanuki Nov 16, 2024

arneke Nov 16, 2024

monsieurtanuki Nov 17, 2024

monsieurtanuki commented Nov 16, 2024

monsieurtanuki commented Nov 16, 2024

josxha commented Nov 16, 2024

josxha left a comment

monsieurtanuki commented Nov 17, 2024

		urlTemplate:
		'https://maps.trafikinfo.trafikverket.se/MapService/wmts.axd/BakgrundskartaNorden.gpkg?layer=Background&style=default&tilematrixset=Default.256.3006&Service=WMTS&Request=GetTile&Version=1.0.0&Format=image%2Fpng&TileMatrix={z}&TileCol={x}&TileRow={y}')

fix: make horizontal repetition CRS dependent #1978

Are you sure you want to change the base?

fix: make horizontal repetition CRS dependent #1978

Conversation

monsieurtanuki commented Oct 16, 2024

What

Files

arneke commented Oct 17, 2024

monsieurtanuki commented Oct 17, 2024

JaffaKetchup left a comment

Choose a reason for hiding this comment

JaffaKetchup left a comment

Choose a reason for hiding this comment

monsieurtanuki commented Nov 13, 2024

josxha left a comment

Choose a reason for hiding this comment

josxha Nov 16, 2024

Choose a reason for hiding this comment

monsieurtanuki Nov 16, 2024

Choose a reason for hiding this comment

arneke Nov 16, 2024

Choose a reason for hiding this comment

monsieurtanuki Nov 17, 2024

Choose a reason for hiding this comment

monsieurtanuki commented Nov 16, 2024

monsieurtanuki commented Nov 16, 2024

josxha commented Nov 16, 2024

josxha left a comment

Choose a reason for hiding this comment

monsieurtanuki commented Nov 17, 2024