-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gestures): double tap zoom events, fling events #1815
fix(gestures): double tap zoom events, fling events #1815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested, will test as part of main PR. Code LGTM. Thanks!
AnimationEndedCallback? onAnimatedEnded, | ||
AnimationCancelledCallback? onAnimationCancelled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could there be any use in having these callbacks exposed through MapOptions
? Again, need to consider if we're adding too many callbacks and whether there's a better way to do it (eg. more event types, remove callbacks except onMapEvent
) - but that's a discussion for another time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alowing the user to listen for it makes indeed sense but isn't this already possible with the event system?
Side note: these callbacks are not persistent, they are only for one animation and get cleared afterwards.
Issue
(4) Double tap zoom no longer emits correct event.
(3) One bug with fling event end/finished event not being emmitted (when fling is cancelled with tap (as shown in video), or when finished naturally)
2024-01-22.20-47-41.mp4
Information
doubleTapZoomIn
and the fling animation of thedrag
gesture.