Fixed crash on uncaught "Invalid image data" exception #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bytes (MacOS desktop). When running a custom tile server, in the case of a missing tile we can get back zero bytes. Resulting in the **decode** function failure in **_loadAsync** of FlutterMapNetworkImageProvider. Looking at the **_loadAsync** implementation, the call to the **decode** function was left out of the try/catch block. Simply moving the **decode** function call inside the try block fixes the issue - the app no longer crashes on a missing tile.
|
Hey @s6o, thanks for this! Would it be possible for you also to create a bug report? |
|
JaffaKetchup
added a commit
to fleaflet/flutter_map_cancellable_tile_provider
that referenced
this pull request
Sep 10, 2023
Hey, I've done so: Bug report |
JaffaKetchup
changed the title
JaffaKetchup
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a custom tile server, in the case of a missing tile we can get back zero bytes. Resulting in the decode function failure in _loadAsync of FlutterMapNetworkImageProvider.
Looking at the _loadAsync implementation, the call to the decode function was left out of the try/catch block. Simply moving the decode function call inside the try block fixes the issue - the app no longer crashes on a missing tile.