-
-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate obsolete fit parameter #1368
Deprecate obsolete fit parameter #1368
Conversation
(dammit not another one :D) We'll get round to looking at this, please don't take the silence badly :) |
I knew that this PR wouldn't be welcomed with joy. 😅 Since this has no importance at all it would probably make sense to delay this PR till another more relevant breaking change kicks in. But maybe it also turns out that the removed property has an actual usage. |
Nah, I was more annoyed that someone found yet another 'remnant of the old world' as I call them! Thanks for the PR, they are always appreciated. As this literally did nothing, no one should be using it (or if they are, they shouldn't care that it's gone), and therefore I wouldn't call it a breaking change, just a minor change (v0.x.0). I'm quite busy atm, so I'll see what I can get done when :) |
I have a suggestion, as this is a "breaking change" even if the parameter is not used, it could be considered to deprecate it and force to use class FitBoundsOptions {
final EdgeInsets padding;
final double maxZoom;
final bool inside;
const FitBoundsOptions({
this.padding = EdgeInsets.zero,
this.maxZoom = 17.0,
@Deprecated('This property is never used, use MapOptions.zoom instead.')
double? zoom,
this.inside = false,
});
} |
Sure, that seems sensible. |
Sounds good to me. The only question I have is, should we really point to the |
Then I guess you can just put: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of @TesteurManiak.
I always wondered what the use of the
zoom
parameter of theFitBoundsOptions
class was.When working on #1367 I finally had the chance to look into it. As it turns out this parameter is never used nor is it documented.
Since this is a somewhat breaking change I made a separate PR.