trigger event on scroll wheel #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
approved these changes
Mar 11, 2022
ibrierley
reviewed
Mar 13, 2022
|
I don't expect any issue between the 2 PR (except the merge conflict because there's a line that is changed on the 2 PR) |
|
happy to merge this I think, have tested it doesn't seem to break anything obvious...noting the question about PR 1191, not so familiar with merge conflicts (it currently says there aren't any...), does it matter which order they are merged in or anything ? |
|
@ibrierley It does depend on whichever gets merged first will cause a conflict in the other. |
|
Testing now... |
JaffaKetchup
approved these changes
Mar 20, 2022
There was a problem hiding this comment.
LGTM, works as expected when tested. Will merge this before #1191.
|
Many thanks for your contribution @a14n. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
MapEventScrollWheelZoomevent that is fired when a scroll wheel occurs. Currently no event is triggered on scroll wheel (and zoom change)